EOracleError should be EDatabaseError descendant

[Sindre Barstad]

I would like to suggest that the EOracleError exception should be a EDatabaseError descendant.
(instead of Excpeiont). Tools like Reportbuilder will often catch the EDatabaseError exception, and then exceptions from DOA will be unhandled. That makes it difficult to add "good" and seamless DOA support to other third party tools.

 

[Marco Kalter]

The TOracleDataSet does raise EDatabaseError exceptions, but it can indeed simplify things if EOracleError would descend from EDatabaseError.

 

[Sindre Barstad]

Do that meen that you will change it in the next release?

 

[benthicsoftware]

I may be wrong about this but wouldn't that change make it so that the DB unit would always have to be included in DOA apps? I actually like the ability (using the NODATASET define) to remove DB if we don't use it. Perhaps not a big issue but something to consider.

 

[Marco Kalter]

We'll look into this. The Oracle unit should of course not include the DB unit when NODATASET is defined. It will descend from Exception if NODATASET is defined, and from EDatabaseError if it is not defined.

We'll also need to check if there are no compatibility issues with existing applications.