Small inconsistency in the DOA code (?)

[al0]

Hi,

I by chance have noticed that in the DOA 4.0.3 code in TQBEField.GetQueryable procedure in the OracleData unit the following list is used as list of not querable LOB fields

[ftBlob, ftGraphic, ftMemo
{$IFDEF CompilerVersion5}, ftOraClob, ftOraBlob {$ENDIF}]

in TQBEEditForm.UpdateFieldDef in unit OracleQBEEdit the [ftBlob, ftGraphic, ftMemo] only

and back in OracleData unit in TColumnExpression.GetExprType the ftFmtMemo is present additionally.

I guess, that field types, considered shall be consistent over the code (even if inconsitency is harmless, as IMHO in this case).

BTW, Delphi (at least D5 and above, has no access to previous version to check) has in DB unit constan arrays BlobDFieldTypes (really contains not only BLOBs but any LOBs) and StringFieldTypes.
May be it would be safer to use them or define your own constant arrays and use them over the whole code for checks?

 

[al0]

Originally posted by al0:
has in DB unit constan arrays BlobDFieldTypes (really contains not only BLOBs but any LOBs) and StringFieldTypes.
May be it would be safer to use them or define your own constant arrays and use them over the whole code for checks?

I was wrong those constan arrays are declared in implementation section of DB unit, so are not available from outside of units.

Sorry