Error in destructor of TLOBLocator

[WODOA]

Dear developers!

I found error in TLOBLocator.Destroy

......TLOBLocator.Destroy......
  ...
  if (FLOB <> nil) then
  begin
    PLOB := @FLOB;
    if Temporary then
      // in this line
      OCICall(OCILOBFreeTemporary(Session.svchp, errhp, FLOB));
    OCIDescriptorFree(FLOB, LOBDType);
  end;
  ...

OCICall raise exception in Destructor!!!.

sample:

var
  LOB: TLOBLocator;
begin
  OraSession.LogOn;
  LOB := TLOBLocator.CreateTemporary(OraSession, NewVarType, False);
  try
    ...
    set LOB as complex var
    execute TOracleQuery
    ..
    LOB.Read(...);
    OraSession.LogOff; // as sample
  finally
    LOB.Free; // Exception!!
  end;
  // Memory Leak!!!! Do not destroy LOB, because Exception
end;

 

[Marco Kalter]

OCILOBFreeTemporary should not lead to an exception. That would be abnormal behavior.

 

[WODOA]

Code from Destructor TLOBLOcator

OCICall(OCILOBFreeTemporary(Session.svchp, errhp, FLOB));

OCICall code

procedure TLOBLocator.OCICall(Err: Integer);
begin
  case Err of
    OCI_ERROR: RaiseOracleError(Session, integer(errhp), Self);
    OCI_INVALID_HANDLE: raise Exception.Create('TLOBLocator: Invalid handle');
  end;
end;

OCICall() raise an exception if Session is logged off.